What am i doing wrong?

Question:
i just can’t make my code work at all.


Repl link:
https://replit.com/@coding-for-web-spring-23/Milestone-Ask-the-Magic-8-Ball-gtesoro#script.js

function onAnswerRequested() {
      let answerText = supplyAnswer(answerText)

      if (answerType === "positive") {
        if (answerText === "") {
          alert(NO_QUESTION_WARNING);
        } else {
          sendAnswer(answerText);
        }


      } else if (answerType === "negative") {
        if (answerText === " ") {
          alert(NO_QUESTION_WARNING);
        } else {
          sendAnswer(answerText);
        } 

      } else {
          sendAnswer(answerText);
        }
      }

    } onAnswerRequestedTest();

Hey @gtesoro! Welcome to the community!

You will need to put quotes around the alert()
function like so:

alert('NO_QUESTION_WARNING');
1 Like

hi @savardo. the NO_QUESTION_WARNING is a string.
const NO_QUESTION_WARNING = "You need to ask a question!";

1 Like

Please use triple backticks ` to display your code like this:

const NO_QUESTION_WARNING = "You will need to ask a question!";

Constants should be declared in all caps.

3 Likes

**HERES THE WHOLE THING. My console says onAnswerRequested() is undefined **

function chooseRandomAnswerType() {
  let randomNumber = getRandomNumber(0, 2);

  if (randomNumber === 0) {
    return "positive";
  } else if (randomNumber === 1) {
    return "negative";
  } else {
    return "maybe";

  }

  chooseRandomAnswerTypeTest();

  function chooseRandomAnswer(answerType) {
    if (answerType === "positive") {
      return positiveAnswers[getRandomNumber(0, positiveAnswers.length - 1)];
    } else if (answerType === "negative") {
      return negativeAnswers[getRandomNumber(0, negativeAnswers.length - 1)];
    } else {
      return maybeAnswers[getRandomNumber(0, maybeAnswers.length - 1)];
    }

    chooseRandomAnswerTest();


    function onAnswerRequested() {
      let answerText = supplyAnswer(answerText)

      if (answerType === "positive") {
        if (answerText === "") {
          alert(NO_QUESTION_WARNING);
        } else {
          supplyAnswer(answerText);
        }


      } else if (answerType === "negative") {
        if (answerText === "") {
          alert(NO_QUESTION_WARNING);
        } else {
          supplyAnswer(answerText);
        } 

      } else {
          supplyAnswer(answerText);
        }
      }
    }
  }
  onAnswerRequestedTest();

Just read the error: onAnswerRequested() is undefined tells you that the function is missing. You will need to create the function in order for your program to work.

2 Likes